linux-kernel - Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jan 2013 15:03:06 +0400
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	Arnd Bergmann <arnd.bergmann@...aro.org>
CC:	<linux-kernel@...r.kernel.org>, <grant.likely@...retlab.ca>,
	<Vineet.Gupta1@...opsys.com>, <benh@...nel.crashing.org>,
	<monstr@...str.eu>
Subject: Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16
 with generic iowrite(read)8/16(be)

On 01/29/2013 08:27 PM, Arnd Bergmann wrote:
> On Tuesday 29 January 2013, Alexey Brodkin wrote:
>> in(out)_8/in(out)_be16/in(out)_le16 are very powerpc/microblaze
>> specific. To enable use of Xilinx System ACE driver build for other
>> architectures (for example it's possible to use it on Xilinx ml-509
>> board with ARC700 in FPGA) we need to use generic implementation of
>> accessors.
>>
>> Current implementation was successfully built with Sourcery G++ Lite
>> 2011.03-39 for Power EABI (ppc44x_defconfig).
>>
>> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
>
> Is this driver used on powerpc64 as well, or just on microblaze
> and/or 32 bit powerpc?
>
> On 64 bit powerpc, ioread involves extra overhead because it
> goes through the PCI error handling implementation, so we should
> keep using in_le() there.	
>
> 	Arnd
>

Personally I have no idea about usage of the named device on powerpc64.
Wondering if anybody may comment on this?

My only intention was to make the driver portable.
Do you think if there's another generic alternative for originally used 
accessors?

For example will it be better with "readb/readw/writeb/writew"?

-Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/