linux-kernel - Re: [PATCH v2] Add 4 tracepoint events for vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1359549018.17639.90.camel@gandalf.local.home>
Date:	Wed, 30 Jan 2013 07:30:18 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	chenggang <chenggang.qin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	David Ahern <dsahern@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Namhyung Kim <namhyung@...il.com>,
	Yanmin Zhang <yanmin.zhang@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Mike Galbraith <efault@....de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chenggang Qin <chenggang.qcg@...baba-inc.com>
Subject: Re: [PATCH v2] Add 4 tracepoint events for vfs

On Wed, 2013-01-30 at 14:35 +0800, chenggang wrote:
> +#include <asm/ptrace.h>
> +
> +DECLARE_EVENT_CLASS(vfs_filerw_template,
> +
> +	TP_PROTO(long long pos, unsigned long bytes, unsigned char *fname),

One last nit. Might want to make fname "const".

-- Steve

> +
> +	TP_ARGS(pos, bytes, fname),
> +
> +	TP_STRUCT__entry(
> +		__field(        long long,      pos             )
> +		__field(        unsigned long,  bytes           )
> +		__string(       fname,          fname           )
> +	),
> +
> +	TP_fast_assign(
> +		__entry->pos    = pos;
> +		__entry->bytes  = bytes;
> +		__assign_str(fname, fname);
> +	),
> +
> +	TP_printk("Filename: %s Pos: %lld Bytes: %lu",
> +		  __get_str(fname), __entry->pos, __entry->bytes)
> +);
> +


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/