| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Jan 2013 14:53:37 +0100
From: Fabio Baltieri <fabio.baltieri@...aro.org>
To: "Rafael J. Wysocki" <rjw@...k.pl>, cpufreq@...r.kernel.org,
linux-pm@...r.kernel.org, Viresh Kumar <viresh.kumar@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, swarren@...dotorg.org,
linaro-dev@...ts.linaro.org,
Nicolas Pitre <nicolas.pitre@...aro.org>,
mathieu.poirier@...aro.org, Joseph Lo <josephl@...dia.com>,
linux-kernel@...r.kernel.org,
Fabio Baltieri <fabio.baltieri@...aro.org>
Subject: [PATCH] cpufreq: governors: clean timer init and exit code
Drop unused arguments from dbs_timer_init and clean dbs_timer_exit and
cpufreq_governor_dbs to remove non necessary special cases.
Reported-by: Viresh Kumar <viresh.kumar@...aro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@...aro.org>
---
Hello Rafael,
that's the cleanup on top of "cpufreq: handle SW coordinated CPUs".
Thanks,
Fabio
drivers/cpufreq/cpufreq_governor.c | 43 ++++++++++++--------------------------
1 file changed, 13 insertions(+), 30 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
index ee8b7ca..46f96a4 100644
--- a/drivers/cpufreq/cpufreq_governor.c
+++ b/drivers/cpufreq/cpufreq_governor.c
@@ -169,19 +169,19 @@ bool dbs_sw_coordinated_cpus(struct cpu_dbs_common_info *cdbs)
}
EXPORT_SYMBOL_GPL(dbs_sw_coordinated_cpus);
-static inline void dbs_timer_init(struct dbs_data *dbs_data,
- struct cpu_dbs_common_info *cdbs,
- unsigned int sampling_rate,
- int cpu)
+static inline void dbs_timer_init(struct dbs_data *dbs_data, int cpu,
+ unsigned int sampling_rate)
{
int delay = delay_for_sampling_rate(sampling_rate);
- struct cpu_dbs_common_info *cdbs_local = dbs_data->get_cpu_cdbs(cpu);
+ struct cpu_dbs_common_info *cdbs = dbs_data->get_cpu_cdbs(cpu);
- schedule_delayed_work_on(cpu, &cdbs_local->work, delay);
+ schedule_delayed_work_on(cpu, &cdbs->work, delay);
}
-static inline void dbs_timer_exit(struct cpu_dbs_common_info *cdbs)
+static inline void dbs_timer_exit(struct dbs_data *dbs_data, int cpu)
{
+ struct cpu_dbs_common_info *cdbs = dbs_data->get_cpu_cdbs(cpu);
+
cancel_delayed_work_sync(&cdbs->work);
}
@@ -289,36 +289,19 @@ second_time:
}
mutex_unlock(&dbs_data->mutex);
- if (dbs_sw_coordinated_cpus(cpu_cdbs)) {
- /* Initiate timer time stamp */
- cpu_cdbs->time_stamp = ktime_get();
+ /* Initiate timer time stamp */
+ cpu_cdbs->time_stamp = ktime_get();
- for_each_cpu(j, policy->cpus) {
- struct cpu_dbs_common_info *j_cdbs;
-
- j_cdbs = dbs_data->get_cpu_cdbs(j);
- dbs_timer_init(dbs_data, j_cdbs,
- *sampling_rate, j);
- }
- } else {
- dbs_timer_init(dbs_data, cpu_cdbs, *sampling_rate, cpu);
- }
+ for_each_cpu(j, policy->cpus)
+ dbs_timer_init(dbs_data, j, *sampling_rate);
break;
case CPUFREQ_GOV_STOP:
if (dbs_data->governor == GOV_CONSERVATIVE)
cs_dbs_info->enable = 0;
- if (dbs_sw_coordinated_cpus(cpu_cdbs)) {
- for_each_cpu(j, policy->cpus) {
- struct cpu_dbs_common_info *j_cdbs;
-
- j_cdbs = dbs_data->get_cpu_cdbs(j);
- dbs_timer_exit(j_cdbs);
- }
- } else {
- dbs_timer_exit(cpu_cdbs);
- }
+ for_each_cpu(j, policy->cpus)
+ dbs_timer_exit(dbs_data, j);
mutex_lock(&dbs_data->mutex);
mutex_destroy(&cpu_cdbs->timer_mutex);
--
1.7.12.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists