linux-kernel - Re: [PATCH 0/9][v2] dasd: implement block timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFD72BD141.262FC15D-ONC1257B03.00583EF8-C1257B03.00595C7E@de.ibm.com>
Date:	Wed, 30 Jan 2013 17:15:54 +0100
From:	Stefan Weinhuber <WEIN@...ibm.com>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Hannes Reinecke <hare@...e.de>, heicars2@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org, mschwid2@...ux.vnet.ibm.com
Subject: Re: [PATCH 0/9][v2] dasd: implement block timeout

Hannes Reinecke <hare@...e.de> wrote on 2013-01-30 10:26:10:
> This patch series implements a block timeout handler for
> DASDs. The main impetus was to allow for a fixed upper
> timeout value after which a request is aborted.
> This is required eg when implementing a host-based
> mirroring system where otherwise the entire mirror
> would stall under certain circumstances.
> 
> Changes since v1:
> - Fixed lock inversion in dasd_times_out()
> - Checked for 'device->block' when writing to 'timeout' attribute
> - Check against 'UINT_MAX' when verifying the 'timeout' value
> 
> Hannes Reinecke (9):
>   dasd: Clarify comment
>   dasd: make number of retries configurable
>   dasd: process all requests in the device tasklet
>   dasd: Implement block timeout handling
>   dasd: Reduce amount of messages for specific errors
>   dasd: detailed I/O errors
>   block: check for timeout function in blk_rq_timed_out()
>   dasd: Add 'timeout' attribute
>   dasd: Fail all requests when DASD_FLAG_ABORTIO is set
> 
>  arch/s390/include/uapi/asm/dasd.h |    4 +
>  block/blk-core.c                  |    3 +
>  block/blk-timeout.c               |    5 +-
>  drivers/s390/block/dasd.c         |  115 ++++++++++++++++++++++++++
> +++++++----
>  drivers/s390/block/dasd_devmap.c  |   97 
+++++++++++++++++++++++++++++++
>  drivers/s390/block/dasd_diag.c    |    8 ++-
>  drivers/s390/block/dasd_eckd.c    |   15 ++++-
>  drivers/s390/block/dasd_erp.c     |    8 +++
>  drivers/s390/block/dasd_fba.c     |   10 +++-
>  drivers/s390/block/dasd_int.h     |   10 +++
>  drivers/s390/block/dasd_ioctl.c   |   59 +++++++++++++++++++
>  11 files changed, 313 insertions(+), 21 deletions(-)
> 
> -- 
> 1.7.4.2
> 

This patch set looks fine to me now. Thanks!

Acked-by: Stefan Weinhuber <wein@...ibm.com>

Mit freundlichen Grüßen / Kind regards
 
Stefan Weinhuber

-- 
Linux for zSeries kernel development
IBM Systems &Technology Group, Systems Software Development / SW Linux für 
zSeries Entwicklung

IBM Deutschland
Schoenaicher Str. 220
71032 Boeblingen
Phone: +49-7031-16-4018
E-Mail: wein@...ibm.com

IBM Deutschland Research & Development GmbH / Vorsitzender des 
Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, 
HRB 243294

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/