linux-kernel - [tip:x86/urgent] samsung-laptop: Disable on EFI hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-309176501502073be48627b4e6196e8f0cc2ea60@git.kernel.org>
Date:	Wed, 30 Jan 2013 10:36:37 -0800
From:	tip-bot for Matt Fleming <matt.fleming@...el.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	mjg59@...f.ucam.org, stable@...r.kernel.org, corentincj@...aif.net,
	matt.fleming@...el.com, steve.langasek@...onical.com,
	colin.king@...onical.com, tglx@...utronix.de, hpa@...ux.intel.com
Subject: [tip:x86/urgent] samsung-laptop: Disable on EFI hardware

Commit-ID:  309176501502073be48627b4e6196e8f0cc2ea60
Gitweb:     http://git.kernel.org/tip/309176501502073be48627b4e6196e8f0cc2ea60
Author:     Matt Fleming <matt.fleming@...el.com>
AuthorDate: Mon, 21 Jan 2013 20:40:38 +0000
Committer:  H. Peter Anvin <hpa@...ux.intel.com>
CommitDate: Wed, 30 Jan 2013 08:58:36 -0800

samsung-laptop: Disable on EFI hardware

It has been reported that running this driver on some Samsung laptops
with EFI can cause those machines to become bricked as detailed in the
following report,

	https://bugs.launchpad.net/ubuntu-cdimage/+bug/1040557

There have also been reports of this driver causing Machine Check
Exceptions on recent EFI-enabled Samsung laptops,

	https://bugzilla.kernel.org/show_bug.cgi?id=47121

So disable it if booting from EFI since this driver relies on
grovelling around in the BIOS memory map which isn't going to work.

Cc: Corentin Chary <corentincj@...aif.net>
Cc: Matthew Garrett <mjg59@...f.ucam.org>
Cc: Colin Ian King <colin.king@...onical.com>
Cc: Steve Langasek <steve.langasek@...onical.com>
Cc: <stable@...r.kernel.org>
Signed-off-by: Matt Fleming <matt.fleming@...el.com>
Link: http://lkml.kernel.org/r/1358800838-10459-3-git-send-email-matt@console-pimps.org
Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
---
 drivers/platform/x86/samsung-laptop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 71623a2..0ffcfc4 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1544,6 +1544,9 @@ static int __init samsung_init(void)
 	struct samsung_laptop *samsung;
 	int ret;
 
+	if (efi_enabled(EFI_BOOT))
+		return -ENODEV;
+
 	quirks = &samsung_unknown;
 	if (!force && !dmi_check_system(samsung_dmi_table))
 		return -ENODEV;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/