linux-kernel - Re: [PATCH] KEXEC: Get rid of duplicate check for hole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87boc74ev0.fsf@xmission.com>
Date:	Tue, 29 Jan 2013 17:52:03 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Cc:	"kexec\@lists.infradead.org" <kexec@...ts.infradead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KEXEC: Get rid of duplicate check for hole_end

Zhang Yanfei <zhangyanfei@...fujitsu.com> writes:

> hole_end has been checked to make sure it is <= crash_res.end in the
> while condition check, so the if condition check is duplicate.

That test is definitely a duplicate.

Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com>

> Signed-off-by: Zhang Yanfei <zhangyanfei@...fujitsu.com>
> ---
>  kernel/kexec.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 5e4bd78..c2826fc 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -497,8 +497,6 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
>  
>  		if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
>  			break;
> -		if (hole_end > crashk_res.end)
> -			break;
>  		/* See if I overlap any of the segments */
>  		for (i = 0; i < image->nr_segments; i++) {
>  			unsigned long mstart, mend;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/