linux-kernel - Re: [PATCH Bug fix] acpi, movablemem_map: node0 should always be unhotpluggable when using SRAT.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1301301445270.27852@chino.kir.corp.google.com>
Date:	Wed, 30 Jan 2013 14:48:13 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Tang Chen <tangchen@...fujitsu.com>
cc:	akpm@...ux-foundation.org, jiang.liu@...wei.com,
	wujianguo@...wei.com, hpa@...or.com, wency@...fujitsu.com,
	laijs@...fujitsu.com, linfeng@...fujitsu.com, yinghai@...nel.org,
	isimatu.yasuaki@...fujitsu.com, rob@...dley.net,
	kosaki.motohiro@...fujitsu.com, minchan.kim@...il.com,
	mgorman@...e.de, guz.fnst@...fujitsu.com, rusty@...tcorp.com.au,
	lliubbo@...il.com, jaegeuk.hanse@...il.com, tony.luck@...el.com,
	glommer@...allels.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH Bug fix] acpi, movablemem_map: node0 should always be
 unhotpluggable when using SRAT.

On Wed, 30 Jan 2013, Tang Chen wrote:

> > Exactly, there is a node 0 but it includes no online memory (and that
> > should be the case as if it was solely hotpluggable memory) at the time of
> > boot.  The sysfs interfaces only get added if the memory is onlined later.
> 
> OK, you mean you have only node1 at first and no node0 interface, right?
> If so, then this patch is wrong. :)
> 

Not usually unless I modify my SRAT or I start pulling DIMMs, but yes, 
I've booted the kernel many times in the past with no node 0 online.  As 
far as I know, there's no special casing that is needed for node 0 to 
assume it's online and I've tried to fix up places where that assumption 
has been made.  I'm sure that node_online_map must include at least one 
online node, obviously, but there should be no requirement that it be node 
0.

> But you mean physical address 0x0 is on your node1, right? Otherwise, how
> could
> the kernel be loaded ?
> 

Yes, the online pxms all point to nodes that do not have the node id of 0.

Is it possible to try earlyprintk and get a serial console connected or 
reproduce it locally to find out where the problem is?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/