linux-kernel - Re: [RFC PATCH v3 1/2] ARM: kernel: update cpuinfo to print SoC model name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130130232408.GL2637@n2100.arm.linux.org.uk>
Date:	Wed, 30 Jan 2013 23:24:08 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Nicolas Pitre <nico@...xnic.net>
Cc:	Ruslan Bilovol <ruslan.bilovol@...com>,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, tony@...mide.com,
	eduardo.valentin@...com
Subject: Re: [RFC PATCH v3 1/2] ARM: kernel: update cpuinfo to print SoC
	model name

On Wed, Jan 30, 2013 at 02:07:53PM -0500, Nicolas Pitre wrote:
> On Wed, 30 Jan 2013, Ruslan Bilovol wrote:
> 
> > Currently, reading /proc/cpuinfo provides userspace with CPU ID of
> > the CPU carrying out the read from the file.
> > Userspace using this information may decide what module
> > to load or how to configure some specific (and processor-depended)
> > settings or so.
> > However, since really different SoCs can share same ARM core,
> > this information currently is not so useful.
> > For example, TI OMAP4460 and OMAP4470 SoCs show the same
> > information in the /proc/cpuinfo whereas they are different.
> > Since in most cases ARM CPU is a part of some system on a chip (SoC),
> > the "cpuinfo" file looks like exactly that place, where this
> > information have to be displayed.
> > 
> > So added new line "SoC name" in the "cpuinfo" output for system
> > on a chip name. It is placed between CPU information and machine
> > information, so the file structure looks gracefully (CPU-SoC-Hardware)
> > 
> > Example:
> > 
> > / # cat proc/cpuinfo
> > [...]
> > CPU variant     : 0x2
> > CPU part        : 0xc09
> > CPU revision    : 10
> > 
> > SoC name        : OMAP4470
> > 
> > Hardware        : OMAP4 Blaze Tablet
> 
> Please remove that extra blank line between "SoC name" and "Hardware".  
> The blank line after "CPU revision" is fine.
> 
> Also, please rename this to "System name".  Not all systems are "on 
> chip".  By using "System name" this is more universally useful.

You may notice I've already suggested that this should be using the SoC
infrastructure to export this information, which was explicitly designed
to do this.

If we're going to have one SoC doing one thing and another SoC exporting
this information a completely different way, we're doomed.  We need to
make a decision and do it one way and one way only - and that decision
was made when drivers/base/soc.c was merged.

Unfortunately, I'd forgotten about that when I made my initial comments
about the difference between "CPU" and "SoC".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/