linux-kernel - Re: [PATCH] hlist: drop the node parameter from iterators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130130154725.f7b40daa.akpm@linux-foundation.org>
Date:	Wed, 30 Jan 2013 15:47:25 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	torvalds@...ux-foundation.org,
	Peter Senna Tschudin <peter.senna@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hlist: drop the node parameter from iterators

On Tue, 29 Jan 2013 20:08:30 -0500
Sasha Levin <sasha.levin@...cle.com> wrote:

> Also, ping :)
>
> ...
>
> >  216 files changed, 1031 insertions(+), 1526 deletions(-)

Whimper.

I don't really see a sane way of avoiding a single huge atomic smash
here.  Normally we'd use a multistep process:

1: Create a new and differently named macro, say "sasha_is_a_pita()".

2: Convert hlist_for_each_entry() to sasha_is_a_pita() in as many
   sites as we can.

3: Once we think all sites are converted, delete the now-unused
   hlist_for_each_entry() definition.

Problem is, there just isn't any other identifier we can use here apart
from hlist_for_each_entry().

I suppose we could add additional steps:

4: Add hlist_for_each_entry(), which is identical to sasha_is_a_pita().

5: Convert sasha_is_a_pita() to hlist_for_each_entry() in as many
   sites as we can.

6: Once we think all sites are converted, delete the now-unused
   sasha_is_a_pita() definition.

But geeze.

The alternative is to do the huge atomic smash immediately after the
3.9-rc1 release, when the amount of pending out-of-tree code is at a
minimum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/