linux-kernel - Re: [PATCHv5] tty: Added a CONFIG_TTY option to allow removal of TTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130131051728.GA2961@kroah.com>
Date:	Thu, 31 Jan 2013 06:17:28 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Joe Millenbach <jmillenbach@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Alan Cox <alan@...ux.intel.com>,
	Jiri Slaby <jirislaby@...il.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Josh Triplett <josh@...htriplett.org>,
	Jamey Sharp <jamey@...ilop.net>
Subject: Re: [PATCHv5] tty: Added a CONFIG_TTY option to allow removal of TTY

On Wed, Jan 30, 2013 at 05:15:19PM -0800, Joe Millenbach wrote:
> The option allows you to remove TTY and compile without errors. This
> saves space on systems that won't support TTY interfaces anyway.
> bloat-o-meter output is below.
> 
> The bulk of this patch consists of Kconfig changes adding "depends on
> TTY" to various serial devices and similar drivers that require the TTY
> layer.  Ideally, these dependencies would occur on a common intermediate
> symbol, but many drivers select rather than depend on features, and
> "select" does not respect dependencies.
> 
> bloat-o-meter output filtered to not show removed entries to save space
> 
> $ scripts/bloat-o-meter min min-no-tty | awk '$3 != "-"'
> add/remove: 0/225 grow/shrink: 2/12 up/down: 8/-29628 (-29620)
> function                                     old     new   delta
> chr_dev_init                                 138     145      +7
> linux_banner                                 123     124      +1
> static.__warned                              132     131      -1
> unregister_console                           106     101      -5
> start_kernel                                 467     462      -5
> register_console                             545     540      -5
> copy_from_user                                40      35      -5
> sys_setsid                                   105      98      -7
> sys_vhangup                                   27      15     -12
> do_exit                                     1363    1346     -17
> arch_local_irq_save                          136     116     -20
> bitmap_zero                                   44      22     -22
> release_task                                 587     562     -25
> static.spin_unlock_irqrestore                223     187     -36
> 
> Signed-off-by: Joe Millenbach <jmillenbach@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> Reviewed-by: Jamey Sharp <jamey@...ilop.net>
> ---
> v5: Rebasing to 3.8 rc5 and minimized driver/input changes based on input
>     from Dmitry Torokhov.

This isn't going to work because I've already applied this to my tree.
Can you just make a tiny patch against the tty-next git tree to fix up
the differences here for the Input drivers and I can apply that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/