linux-kernel - Re: [PATCH V3] drm_crtc: check if fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKMK7uH3Og8Fi-w98BQtU61=B4cVzOv241L9eg9qHOekEUqs1w@mail.gmail.com>
Date:	Thu, 31 Jan 2013 09:22:42 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	"Su, Xuemin" <xuemin.su@...el.com>, Dave Airlie <airlied@...il.com>
Cc:	Jani Nikula <jani.nikula@...ux.intel.com>,
	"He, Bo" <bo.he@...el.com>,
	"yanmin_zhang@...ux.intel.com" <yanmin_zhang@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL

On Thu, Jan 31, 2013 at 1:55 AM, Su, Xuemin <xuemin.su@...el.com> wrote:
> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@...ux.intel.com]
> Sent: Thursday, January 24, 2013 5:05 PM
> To: Su, Xuemin
> Cc: airlied@...ux.ie; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; yanmin_zhang@...ux.intel.com; He, Bo
> Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL
>
>>Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
>>BUG_ON() is making it clear what's expected of the drivers.
>
>>Reviewed-by: Jani Nikula <jani.nikula@...el.com>
>
> Do you think this patch is still needed?
> Currently I fix a buggy function radeon_user_framebuffer_create() which returns NULL and patch is added to 3.7-stable tree.
> Do you think it's also needed to do something in drm_mode_addfb()?

Imo it's still useful, just to document the assumptions of the interface. Dave?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/