lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <510A4F52.7050008@mev.co.uk>
Date:	Thu, 31 Jan 2013 11:02:42 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Sebastiaan de Haan <sebastiaan@...astiaandehaan.nl>
CC:	Ian Abbott <ian.abbott@....co.uk>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: comedi: made range.c checkpatch.pl compliant

On 2013-01-31 10:56, Sebastiaan de Haan wrote:
> Change made to range.c to make it checkpatch.pl compliant
>
> Signed-off-by: Sebastiaan de Haan <sebastiaan@...astiaandehaan.nl>
> ---
>   drivers/staging/comedi/range.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
> index 59ff0cf..b87fb4e 100644
> --- a/drivers/staging/comedi/range.c
> +++ b/drivers/staging/comedi/range.c
> @@ -35,7 +35,7 @@ const struct comedi_lrange range_unipolar10 = { 1, {UNI_RANGE(10)} };
>   EXPORT_SYMBOL(range_unipolar10);
>   const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
>   EXPORT_SYMBOL(range_unipolar5);
> -const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_none} } };
> +const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_NONE} } };
>   EXPORT_SYMBOL(range_unknown);

No, no, no.  It doesn't compile and UNIT_none is used by user space.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ