linux-kernel - Re: [BUG?] false positive in soft lockup detector while unlzma initramfs on slow cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510A539E.7020105@yandex.ru>
Date:	Thu, 31 Jan 2013 15:21:02 +0400
From:	Mike Lykov <combr@...dex.ru>
To:	Don Zickus <dzickus@...hat.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	kirill@...temov.name
Subject: Re: [BUG?] false positive in soft lockup detector while unlzma initramfs
 on slow cpu


30.01.2013 19:40, Don Zickus пишет:
 > I have never seen usage like 'kernel.watchdog_thresh=30'.  Could you try
 > 'watchdog_thresh=30' instead?

Ok. "kernel.watchdog_thresh=30" is a sysctl presentation, i mixed them 
wrongly.

Your patch about cmd support for 'watchdog_thresh=30' working. I tested 
it: parameter applies and lzma -9 initramfs loading successfully.
If I delete parameter from cmdline - same kernel not boot.

 > I also attached another patch as suggested by Andrew to add a
 > touch_softlockup_watchdog in the unlzma routine.  Probably makes things
 > run a little slower.  Compiled tested only.

In my case (3.2.32) it cannot compile:

   LD      arch/x86/boot/compressed/vmlinux
arch/x86/boot/compressed/misc.o: In function `decompress_kernel':
misc.c:(.text+0x993): undefined reference to `touch_softlockup_watchdog'

---
Mike



 >
 > Cheers,
 > Don
 >
 > diff --git a/lib/decompress_unlzma.c b/lib/decompress_unlzma.c
 > index 32adb73..313f4fa 100644
 > --- a/lib/decompress_unlzma.c
 > +++ b/lib/decompress_unlzma.c
 > @@ -36,6 +36,7 @@
 >   #endif /* STATIC */
 >
 >   #include<linux/decompress/mm.h>
 > +#include<linux/nmi.h>
 >
 >   #define	MIN(a, b) (((a)<  (b)) ? (a) : (b))
 >
 > @@ -648,6 +649,7 @@ STATIC inline int INIT unlzma(unsigned char *buf, 
int in_len,
 >   		}
 >   		if (rc.buffer_size<= 0)
 >   			goto exit_3;
 > +		touch_softlockup_watchdog();
 >   	}
 >
 >   	if (posp)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/