linux-kernel - Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510A56BF.3040804@ti.com>
Date:	Thu, 31 Jan 2013 17:04:23 +0530
From:	kishon <kishon@...com>
To:	Vivek Gautam <gautam.vivek@...sung.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <balbi@...com>
Subject: Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt
 node.

Hi,

On Thursday 31 January 2013 04:50 PM, Vivek Gautam wrote:
> With device tree support in place for dwc3-core layer,
> it gets PHY from "synopsis-dwc3" node.
> Some controllers may not have separate memory maps and interrupts
> for dwc3 core and platform glue layers. In such case only glue
> layer's node will exist.

Not really. As long as you have dwc3 core as a separate device, you can 
add a node for it.
Just that the glue should create a device for dwc3 core using 
of_platform_populate.(You can have a look at 
drivers/usb/dwc3/dwc3-omap.c in usb-next)
> Moreover, SoCs having multiple dwc3 controllers will have multiple
> PHYs, which eventually be added using usb_add_phy_dev(), and not
> using usb_add_phy(). So each dwc3 controller won't be able to
> get PHYs by simply calling devm_usb_get_phy() also.
No. We have added usb_get_phy_dev() for that purpose in the case of non-dt.
I think, instead you can have a patch to use devm_usb_get_phy_dev() here 
and in exynos platform specific code use usb_bind_phy() to bind the phy 
and controller till you change it to dt.
> In such cases, dwc3 should expect PHYs from its parent's node.
NAK.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/