[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAN+gG=GLhnvtJissAsk1WV5_O=RhLg1v5SBaF77F=oW_B01-BA@mail.gmail.com>
Date: Thu, 31 Jan 2013 18:16:37 +0100
From: Benjamin Tissoires <benjamin.tissoires@...il.com>
To: Jiri Kosina <jkosina@...e.cz>
Cc: Andrew Duggan <aduggan@...aptics.com>, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: fix i2c_hid_output_raw_report
On Thu, Jan 31, 2013 at 5:58 PM, Jiri Kosina <jkosina@...e.cz> wrote:
> On Thu, 31 Jan 2013, Benjamin Tissoires wrote:
>
>> i2c_hid_output_raw_report is used by hidraw to forward set_report requests.
>> The current implementation of i2c_hid_set_report needs to take the
>> report_id as an argument. The report_id is stored in the first byte
>> of the buffer in argument of i2c_hid_output_raw_report.
>>
>> Not removing the report_id from the given buffer adds this byte 2 times
>> in the command, leading to a non working command.
>>
>> Reported-by: Andrew Duggan <aduggan@...aptics.com>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...il.com>
>
> Applied, will push it for 3.8 still. Thanks,
Thanks Jiri!
Cheers,
Benjamin
>
> --
> Jiri Kosina
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists