linux-kernel - next-20130128 lockdep whinge in sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2013 13:45:14 -0500
From:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
To:	Shaohua Li <shli@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: next-20130128 lockdep whinge in sys_swapon()

Seen in my linux-next dmesg.  I'm suspecting commit ac07b1ffc:

commit ac07b1ffc27d575013041fb5277dab02c661d9c2
Author: Shaohua Li <shli@...nel.org>
Date:   Thu Jan 24 13:13:50 2013 +1100

    swap: add per-partition lock for swapfile

as (a) it was OK in -20130117, and (b) 'git blame mm/swapfile.c | grep 2013'
shows that commit as the vast majority of changes.

[   42.498669] INFO: trying to register non-static key.
[   42.498670] the code is fine but needs lockdep annotation.
[   42.498671] turning off the locking correctness validator.
[   42.498674] Pid: 1035, comm: swapon Not tainted 3.8.0-rc5-next-20130128 #52
[   42.498675] Call Trace:
[   42.498681]  [<ffffffff81073dc8>] register_lock_class+0x103/0x2ad
[   42.498685]  [<ffffffff812493ad>] ? __list_add_rcu+0xc4/0xdf
[   42.498688]  [<ffffffff81075573>] __lock_acquire+0x108/0xd63
[   42.498691]  [<ffffffff810b482b>] ? trace_preempt_on+0x12/0x2f
[   42.498695]  [<ffffffff81608e6e>] ? sub_preempt_count+0x31/0x43
[   42.498699]  [<ffffffff810fda36>] ? sys_swapon+0x6f9/0x9d9
[   42.498701]  [<ffffffff810764f2>] lock_acquire+0xc7/0x14a
[   42.498703]  [<ffffffff810fda62>] ? sys_swapon+0x725/0x9d9
[   42.498706]  [<ffffffff81605023>] _raw_spin_lock+0x34/0x41
[   42.498708]  [<ffffffff810fda62>] ? sys_swapon+0x725/0x9d9
[   42.498710]  [<ffffffff810fda62>] sys_swapon+0x725/0x9d9
[   42.498712]  [<ffffffff8107520a>] ? trace_hardirqs_on_caller+0x149/0x165
[   42.498715]  [<ffffffff8160be92>] system_call_fastpath+0x16/0x1b
[   42.498719] Adding 2097148k swap on /dev/mapper/vg_blackice-swap.  Priority:-1 extents:1 across:2097148k

Somebody care to sprinkle the appropriate annotations on that code?

Content of type "application/pgp-signature" skipped