linux-kernel - Re: resend----[PATCH] Avoid high order memory allocating with kmalloc, when read large seq file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130131132706.f15f3166.akpm@linux-foundation.org>
Date:	Thu, 31 Jan 2013 13:27:06 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	xtu4 <xiaobing.tu@...el.com>
Cc:	linux-kernel@...r.kernel.org, guifang.tang@...el.com,
	linX.z.chen@...el.com
Subject: Re: resend----[PATCH] Avoid high order memory allocating with
 kmalloc, when read large seq file

On Thu, 31 Jan 2013 14:11:32 +0800
xtu4 <xiaobing.tu@...el.com> wrote:

> [SEQ_FILE] Avoid high order memory allocating with kmalloc
>   when read large seq file

The patch is still horridly mangled by your email client.

The implementation cheerfully ignores my earlier comment: "The
conventional way of doing this is to attempt the kmalloc with
__GFP_NOWARN and if that failed, fall back to vmalloc()."

This code has existed for ten years and this is the first time anyone
has encountered this problem.  Rather than mucking around with the
seq_file code to attempt to fix this, it would be better to fix the
calling code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/