linux-kernel - Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130131222511.GA21654@kroah.com>
Date:	Thu, 31 Jan 2013 23:25:11 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Oleg Nesterov <oleg@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	David Rientjes <rientjes@...gle.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

On Thu, Jan 31, 2013 at 11:32:06PM +0200, Stratos Karafotis wrote:
> This patch restructures code for better readability and easier
> maintenance.

Given that no one is working on it, why does it need to be maintained
easier?  :)

> Also introduces lowmemorykiller.h header file.

Why create a .h file?  Who needs it?  Only create a .h file if some
other .c file needs something in it, never for just one .c file.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/