linux-kernel - [RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5109E454.8040102@jp.fujitsu.com>
Date:	Thu, 31 Jan 2013 12:26:12 +0900
From:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Yinghai Lu <yinghai@...nel.org>, Toshi Kani <toshi.kani@...com>
Subject: [RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c

I forgot to chnage subject. So I resend a patch.

---
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
---
  drivers/pnp/pnpacpi/core.c |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-pm/drivers/pnp/pnpacpi/core.c
===================================================================
--- linux-pm.orig/drivers/pnp/pnpacpi/core.c	2013-01-31 11:04:43.000000000 +0900
+++ linux-pm/drivers/pnp/pnpacpi/core.c	2013-01-31 11:38:47.659849883 +0900
@@ -90,7 +90,7 @@ static int pnpacpi_set_resources(struct
  	pnp_dbg(&dev->dev, "set resources\n");
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return -ENODEV;
  	}
@@ -123,7 +123,7 @@ static int pnpacpi_disable_resources(str
  	dev_dbg(&dev->dev, "disable resources\n");
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return 0;
  	}
@@ -145,7 +145,7 @@ static bool pnpacpi_can_wakeup(struct pn
  	acpi_handle handle;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return false;
  	}
@@ -160,7 +160,7 @@ static int pnpacpi_suspend(struct pnp_de
  	int error = 0;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return 0;
  	}
@@ -197,7 +197,7 @@ static int pnpacpi_resume(struct pnp_dev
  	acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
  	int error = 0;
  
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return -ENODEV;
  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/