linux-kernel - Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130201064841.GB4937@mwanda>
Date:	Fri, 1 Feb 2013 09:48:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, Oleg Nesterov <oleg@...hat.com>,
	linux-kernel@...r.kernel.org,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	David Rientjes <rientjes@...gle.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>
Subject: Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

On Fri, Feb 01, 2013 at 12:48:16AM +0200, Stratos Karafotis wrote:
> I will fix it.

I don't know the status of this driver.

But in general the patch should have been divided up into smaller
changes and sent as a patchset.  It creates a bunch of messy new
globals where it would have been cleaner to use function parameters.
Don't introduce new calls to lowmem_print() because we have better
debugging facilities already in the kernel and don't need more.

Btw, the more things you put into one patch, the more there is to
complain about and the less likely it is to be merged.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/