[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130201021149.GB3416@konrad-lan.dumpdata.com>
Date: Thu, 31 Jan 2013 21:11:50 -0500
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
torvalds@...ux-foundation.org
Cc: Seth Jennings <sjenning@...ux.vnet.ibm.com>,
devel@...verdev.osuosl.org,
Dan Magenheimer <dan.magenheimer@...cle.com>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Minchan Kim <minchan@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Robert Jennings <rcj@...ux.vnet.ibm.com>,
Nitin Gupta <ngupta@...are.org>
Subject: Re: [PATCH] staging: zsmalloc: remove unused pool name
> > > {sigh} you just made me have to edit your patch by hand, you now owe me
> > > a beer...
> > >
> > Should we codify that :-)
> >
> >
> > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> > index c379a2a..f879c60 100644
> > --- a/Documentation/SubmittingPatches
> > +++ b/Documentation/SubmittingPatches
> > @@ -94,6 +94,7 @@ includes updates for subsystem X. Please apply."
> > The maintainer will thank you if you write your patch description in a
> > form which can be easily pulled into Linux's source code management
> > system, git, as a "commit log". See #15, below.
> > +If the maintainer has to hand-edit your patch, you owe them a beer.
> >
> > If your description starts to get long, that's a sign that you probably
> > need to split up your patch. See #3, next.
>
> Yes we do need to codify this, but let's be fair, not everyone likes
> beer:
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c379a2a..d1bec01 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -93,7 +93,9 @@ includes updates for subsystem X. Please apply."
>
> The maintainer will thank you if you write your patch description in a
> form which can be easily pulled into Linux's source code management
> -system, git, as a "commit log". See #15, below.
> +system, git, as a "commit log". See #15, below. If the maintainer has
> +to hand-edit your patch, you owe them the beverage of their choice the
> +next time you see them.
>
> If your description starts to get long, that's a sign that you probably
> need to split up your patch. See #3, next.
Does that mean you owe Linus a whiskey bottle since you didn't properly
sign this patch :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists