linux-kernel - Re: [PATCH] leds-ot200: Fix error caused by shifted mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH9NwWdciqHSkkMSk4CW4XX+d6JSZBnvw52Svu8M4o-PGMQsDA@mail.gmail.com>
Date:	Fri, 1 Feb 2013 16:08:15 +0100
From:	Christian Gmeiner <christian.gmeiner@...il.com>
To:	"GMEINER.Christian" <C.GMEINER@...hmann.info>
Cc:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds-ot200: Fix error caused by shifted mask

ping
--
Christian Gmeiner, MSc


2013/1/23 GMEINER.Christian <C.GMEINER@...hmann.info>:
>> -----Ursprüngliche Nachricht-----
>> Von: Christian Gmeiner [mailto:christian.gmeiner@...il.com]
>> Gesendet: Mittwoch, 23. Januar 2013 09:11
>> An: linux-next@...r.kernel.org; akpm@...ux-foundation.org;
>> rpurdie@...ys.net; linux-kernel@...r.kernel.org; GMEINER.Christian
>> Cc: Christian Gmeiner
>> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
>>
>> During the development of this driver an in-house register documentation
>> was used. The last weeks some integration tests were done and this problem
>> was found. It turned out that the released register documentation is wrong.
>>
>> The fix is very simple: shift all masks by one.
>>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@...il.com>
>
>
> Acked-by: Christian Gmeiner <c.gmeiner@...hmann.info>
> Tested-by: Christian Gmeiner <c.gmeiner@...hmann.info>
>
>> ---
>>  drivers/leds/leds-ot200.c | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c index
>> ee14662..98cae52 100644
>> --- a/drivers/leds/leds-ot200.c
>> +++ b/drivers/leds/leds-ot200.c
>> @@ -47,37 +47,37 @@ static struct ot200_led leds[] = {
>>       {
>>               .name = "led_1",
>>               .port = 0x49,
>> -             .mask = BIT(7),
>> +             .mask = BIT(6),
>>       },
>>       {
>>               .name = "led_2",
>>               .port = 0x49,
>> -             .mask = BIT(6),
>> +             .mask = BIT(5),
>>       },
>>       {
>>               .name = "led_3",
>>               .port = 0x49,
>> -             .mask = BIT(5),
>> +             .mask = BIT(4),
>>       },
>>       {
>>               .name = "led_4",
>>               .port = 0x49,
>> -             .mask = BIT(4),
>> +             .mask = BIT(3),
>>       },
>>       {
>>               .name = "led_5",
>>               .port = 0x49,
>> -             .mask = BIT(3),
>> +             .mask = BIT(2),
>>       },
>>       {
>>               .name = "led_6",
>>               .port = 0x49,
>> -             .mask = BIT(2),
>> +             .mask = BIT(1),
>>       },
>>       {
>>               .name = "led_7",
>>               .port = 0x49,
>> -             .mask = BIT(1),
>> +             .mask = BIT(0),
>>       }
>>  };
>>
>> --
>> 1.7.12.2.421.g261b511
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/