linux-kernel - Re: [PATCH] hwmon: (lm90) Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130201213640.GA1606@roeck-us.net>
Date:	Fri, 1 Feb 2013 13:36:40 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Vincent Palatin <vpalatin@...omium.org>
Cc:	Jean Delvare <khali@...ux-fr.org>, lm-sensors@...sensors.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	linux-kernel@...r.kernel.org, Olof Johansson <olofj@...omium.org>,
	Sameer Nanda <snanda@...omium.org>
Subject: Re: [PATCH] hwmon: (lm90) Add device tree support

On Fri, Feb 01, 2013 at 01:18:22PM -0800, Vincent Palatin wrote:
> Add support to instantiate LM90-compatible sensors from a device-tree
> configuration.
> When the kernel has device tree support, we avoid doing the auto-detection
> as probing the busses might mess-up sensitive I2C devices or trigger long
> timeouts on non-functional busses.
> 
> Signed-off-by: Vincent Palatin <vpalatin@...omium.org>

Hi Vincent,

OF support for I2C devices should already work through the I2C subsystem,
without explicit driver patch.

As for the detect function, I am not entirely sure if we want or should get
rid of it just because OF is configured. That may have unintended side effects.
Either case, I would argue that if we do want to do that, it should be done
for _all_ I2C devices and not just for the lm90 driver. In other words, it
should be done in the I2C subsystem, maybe with a separate configuration option.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/