linux-kernel - Re: [PATCH] gpio: mpc8xxx: don't set IRQ_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 03 Feb 2013 11:22:45 +0100
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Anatolij Gustschin <agust@...x.de>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH] gpio: mpc8xxx: don't set IRQ_TYPE_NONE when creating irq mapping

>>>>> "Anatolij" == Anatolij Gustschin <agust@...x.de> writes:

Hi,

 Anatolij> Thomas renamed the old set_irq_type() call to
 Anatolij> irq_set_irq_type(), but this line setting the IRQ_TYPE_NONE
 Anatolij> type was there before renaming.  It was added by commit
 Anatolij> 345e5c8a. At this time set_irq_type() checked its type
 Anatolij> argument and returned 0 if the type argument didn't specify
 Anatolij> some meaningful type in its type sense bits (and thus was
 Anatolij> equal to IRQ_TYPE_NONE). Effectively this line was a nop and
 Anatolij> I wonder what was the point of adding it.

Sorry, don't recall. It's been quite a while, and I've haven't worked on
anything mpc8xxx for a few years by now. Most likely one of the other
gpio drivers did it like this back then.

I don't remember the details, but your description makes sense so if
nobody disagrees you can have my:

Acked-by: Peter Korsgaard <jacmet@...site.dk>

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/