linux-kernel - Re: [PATCH V2 3/6] ARM: davinci: da850: add DT node for I2C0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510E5CC1.8050801@ti.com>
Date:	Sun, 3 Feb 2013 18:19:05 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	"Vishwanathrao Badarkhe, Manish" <manishv.b@...com>
CC:	<devicetree-discuss@...ts.ozlabs.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	<anilkumar@...com>, <tony@...mide.com>, <hs@...x.de>,
	<broonie@...nsource.wolfsonmicro.com>, <sameo@...ux.intel.com>,
	<khilman@...prootsystems.com>, <linus.walleij@...aro.org>,
	<linux@....linux.org.uk>, <rob@...dley.net>,
	<rob.herring@...xeda.com>, <grant.likely@...retlab.ca>
Subject: Re: [PATCH V2 3/6] ARM: davinci: da850: add DT node for I2C0



On 1/29/2013 1:08 PM, Vishwanathrao Badarkhe, Manish wrote:
> Add I2C0 device tree node information to da850-evm.
> Also, add I2C0 pin muxing information in da850-evm.
> 
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@...com>
> ---
> Changes since V1:
>  - Updated i2c0 node names in dts and dtsi file.
>  - Removed interrupt parent from i2c0 node.
>  - Handled i2c0 pin mux inside i2c0 node.
> 
> :100644 100644 433027f... c9ed683... M	arch/arm/boot/dts/da850-evm.dts
> :100644 100644 5e0eb5c... 245ab9a... M	arch/arm/boot/dts/da850.dtsi
>  arch/arm/boot/dts/da850-evm.dts |    5 +++++
>  arch/arm/boot/dts/da850.dtsi    |   15 +++++++++++++++
>  2 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 433027f..c9ed683 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -27,6 +27,11 @@
>  		serial2: serial@...d000 {
>  			status = "okay";
>  		};
> +		i2c0: i2c0@...2000 {

This should be:

i2c0: i2c@...2000

inline with what has been done in rest of this file.

> +			status = "okay";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&i2c0_pins>;
> +		};
>  	};
>  	nand_cs3@...00000 {
>  		status = "okay";
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 5e0eb5c..245ab9a 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -56,6 +56,12 @@
>  					0x30 0x01100000  0x0ff00000
>  				>;
>  			};
> +			i2c0_pins: pinmux_i2c0_pins {
> +				pinctrl-single,bits = <
> +					/* I2C0_SDA,I2C0_SCL */
> +					0x10 0x00002200 0x0000ff00
> +				>;
> +			};
>  		};
>  		serial0: serial@...2000 {
>  			compatible = "ns16550a";
> @@ -81,6 +87,15 @@
>  			interrupts = <61>;
>  			status = "disabled";
>  		};
> +		i2c0: i2c0@...2000 {
> +			compatible = "ti,davinci-i2c";
> +			reg = <0x22000 0x1000>;
> +			clock-frequency = <100000>;

The clock frequency is board specific. This should come from da850-evm.dts.

Also, I think you can merge the auxdata addition with this patch. Can
you post the i2c0 support separate from this series, so it can be taken
independently? Looks like other patches have some dependencies/acks needed.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/