[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <510E8A93.6050300@infradead.org>
Date: Sun, 03 Feb 2013 08:04:35 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Florian Westphal <fw@...len.de>
CC: netfilter-devel@...r.kernel.org, linux-next@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL
On 02/03/13 03:24, Florian Westphal wrote:
> It was possible to set
> NF_CONNTRACK=n
> NF_CONNTRACK_LABELS=y
>
> via NETFILTER_XT_MATCH_CONNLABEL=y:
>
> warning: (NETFILTER_XT_MATCH_CONNLABEL) selects NF_CONNTRACK_LABELS which has
> unmet direct dependencies (NET && INET && NETFILTER && NF_CONNTRACK)
>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Florian Westphal <fw@...len.de>
Acked-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index eb2c8eb..d4dd702 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -860,6 +860,7 @@ config NETFILTER_XT_MATCH_CONNBYTES
> config NETFILTER_XT_MATCH_CONNLABEL
> tristate '"connlabel" match support'
> select NF_CONNTRACK_LABELS
> + depends on NF_CONNTRACK
> depends on NETFILTER_ADVANCED
> ---help---
> This match allows you to test and assign userspace-defined labels names
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists