linux-kernel - Re: [ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510E8F30.8070300@ionic.de>
Date:	Sun, 03 Feb 2013 17:24:16 +0100
From:	Mihai Moldovan <ionic@...ic.de>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Daniel Vetter <daniel.vetter@...ll.ch>,
	Adam Jackson <ajax@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	David Woodhouse <David.Woodhouse@...el.com>,
	stathis <stathis@...glib.org>
Subject: Re: [ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

* On 03.02.2013 03:48 PM, Ben Hutchings wrote:
> [...]
> +static void quirk_iommu_g4x_gfx(struct pci_dev *dev)
> +{
Shouldn't __devinit be used here too, like for quirk_iommu_rwbf?

It probably doesn't matter too much. especially on platforms with Intel IOMMU,
but... it makes the code coherent.

Best regards,


Mihai


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4506 bytes)