linux-kernel - Re: [ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 Feb 2013 21:14:18 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mihai Moldovan <ionic@...ic.de>
Cc:	Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, akpm@...ux-foundation.org,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Adam Jackson <ajax@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	David Woodhouse <David.Woodhouse@...el.com>,
	stathis <stathis@...glib.org>
Subject: Re: [ 092/128] iommu/intel: disable DMAR for g4x integrated gfx

On Sun, Feb 03, 2013 at 05:24:16PM +0100, Mihai Moldovan wrote:
> * On 03.02.2013 03:48 PM, Ben Hutchings wrote:
> > [...]
> > +static void quirk_iommu_g4x_gfx(struct pci_dev *dev)
> > +{
> Shouldn't __devinit be used here too, like for quirk_iommu_rwbf?
> 
> It probably doesn't matter too much. especially on platforms with Intel IOMMU,
> but... it makes the code coherent.

__devinit doesn't do anything on 99% of systems, that's why it is now
gone in 3.8, so no need to keep on adding it to old kernels either.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/