linux-kernel - Re: [PATCH] zsmalloc: Fix TLB coherency and build problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130203235052.GB2688@blaptop>
Date:	Mon, 4 Feb 2013 08:50:52 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matt Sealey <matt@...esi-usa.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Konrad Rzeszutek Wilk <konrad@...nok.org>,
	Nitin Gupta <ngupta@...are.org>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Subject: Re: [PATCH] zsmalloc: Fix TLB coherency and build problem

On Fri, Feb 01, 2013 at 02:02:18PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 28, 2013 at 10:00:08AM +0900, Minchan Kim wrote:
> > @@ -663,7 +661,7 @@ static inline void __zs_unmap_object(struct mapping_area *area,
> >  
> >  	flush_cache_vunmap(addr, end);
> >  	unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
> > -	local_flush_tlb_kernel_range(addr, end);
> > +	flush_tlb_kernel_range(addr, end);
> 
> void unmap_kernel_range_noflush(unsigned long addr, unsigned long size)
> {
>         vunmap_page_range(addr, addr + size);
> }
> 
> void unmap_kernel_range(unsigned long addr, unsigned long size)
> {
>         unsigned long end = addr + size;
> 
>         flush_cache_vunmap(addr, end);
>         vunmap_page_range(addr, end);
>         flush_tlb_kernel_range(addr, end);
> }
> 
> So, given the above, what would be different between:
> 
> 	unsigned long end = addr + (PAGE_SIZE * 2);
> 
> 	flush_cache_vunmap(addr, end);
> 	unmap_kernel_range_noflush(addr, PAGE_SIZE * 2);
> 	flush_tlb_kernel_range(addr, end);
> 
> (which is what it becomes after your change) and
> 
> 	unmap_kernel_range(addr, PAGE_SIZE * 2);
> 
> ?

Good point. I will clean it up.
Thanks.

> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/