| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130204104531.GQ2364@tbergstrom-lnx.Nvidia.com>
Date: Mon, 4 Feb 2013 12:45:31 +0200
From: Peter De Schrijver <pdeschrijver@...dia.com>
To: Prashant Gaikwad <pgaikwad@...dia.com>
CC: Grant Likely <grant.likely@...retlab.ca>,
Rob Herring <rob.herring@...xeda.com>,
Rob Landley <rob@...dley.net>,
Stephen Warren <swarren@...dotorg.org>,
Russell King <linux@....linux.org.uk>,
Simon Glass <sjg@...omium.org>,
Mike Turquette <mturquette@...aro.org>,
Joseph Lo <josephl@...dia.com>,
"devicetree-discuss@...ts.ozlabs.org"
<devicetree-discuss@...ts.ozlabs.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114
On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote:
...
> > +#define RST_DEVICES_L 0x004
> > +#define RST_DEVICES_H 0x008
> > +#define RST_DEVICES_U 0x00C
> > +#define RST_DEVICES_V 0x358
> > +#define RST_DEVICES_W 0x35C
> > +#define RST_DEVICES_X 0x28C
> > +#define RST_DEVICES_SET_L 0x300
> > +#define RST_DEVICES_CLR_L 0x304
> > +#define RST_DEVICES_SET_H 0x308
> > +#define RST_DEVICES_CLR_H 0x30c
> > +#define RST_DEVICES_SET_U 0x310
> > +#define RST_DEVICES_CLR_U 0x314
> > +#define RST_DEVICES_SET_V 0x430
> > +#define RST_DEVICES_CLR_V 0x434
> > +#define RST_DEVICES_SET_W 0x438
> > +#define RST_DEVICES_CLR_W 0x43c
> > +#define RST_DEVICES_NUM 5
>
> RST_DEVICES_SET/CLR_X?
>
For all I can see (from the not yet public TRM), this is not actually used?
So I decided to not mention it here.
> > +
> > +#define CLK_OUT_ENB_L 0x010
> > +#define CLK_OUT_ENB_H 0x014
> > +#define CLK_OUT_ENB_U 0x018
> > +#define CLK_OUT_ENB_V 0x360
> > +#define CLK_OUT_ENB_W 0x364
> > +#define CLK_OUT_ENB_X 0x280
> > +#define CLK_OUT_ENB_SET_L 0x320
> > +#define CLK_OUT_ENB_CLR_L 0x324
> > +#define CLK_OUT_ENB_SET_H 0x328
> > +#define CLK_OUT_ENB_CLR_H 0x32c
> > +#define CLK_OUT_ENB_SET_U 0x330
> > +#define CLK_OUT_ENB_CLR_U 0x334
> > +#define CLK_OUT_ENB_SET_V 0x440
> > +#define CLK_OUT_ENB_CLR_V 0x444
> > +#define CLK_OUT_ENB_SET_W 0x448
> > +#define CLK_OUT_ENB_CLR_W 0x44c
> > +#define CLK_OUT_ENB_SET_X 0x284
> > +#define CLK_OUT_ENB_CLR_X 0x288
> > +#define CLK_OUT_ENB_NUM 6
>
> <snip>
>
> > +
> > + /* dsia */
> > + clk = clk_register_mux(NULL, "dsia_mux", mux_plld_out0_plld2_out0,
> > + ARRAY_SIZE(mux_plld_out0_plld2_out0), 0,
> > + clk_base + PLLD_BASE, 25, 1, 0, &pll_d_lock);
> > + clks[dsia_mux] = clk;
> > + clk = tegra_clk_register_periph_gate("dsia", "dsia_mux", 0, clk_base,
> > + 0, 48, &periph_h_regs,
> > + periph_clk_enb_refcnt);
> > + clk_register_clkdev(clk, "dsia", "tegradc.0");
> > + clks[dsia] = clk;
> > +
> > + /* dsib */
> > + clk = clk_register_mux(NULL, "dsib_mux", mux_plld_out0_plld2_out0,
> > + ARRAY_SIZE(mux_plld_out0_plld2_out0), 0,
> > + clk_base + PLLD2_BASE, 25, 1, 0, &pll_d2_lock);
> > + clks[dsib_mux] = clk;
> > + clk = tegra_clk_register_periph_gate("dsib", "dsib_mux", 0, clk_base,
> > + 0, 82, &periph_u_regs,
> > + periph_clk_enb_refcnt);
> > + clk_register_clkdev(clk, "dsib", "tegradc.1");
> > + clks[dsib] = clk;
> > +
>
> Can we use periph no div clock here for dsia and dsib?
>
Will check.
> > + /* xusb_hs_src */
> > + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC);
> > + val |= BIT(25); /* always select PLLU_60M */
> > + writel(val, clk_base + CLK_SOURCE_XUSB_SS_SRC);
> > +
> > + clk = clk_register_fixed_factor(NULL, "xusb_hs_src", "pll_u_60M", 0,
> > + 1, 1);
> > + clks[xusb_hs_src] = clk;
> > +
>
> With device tree we can directly use pll_u_60M, no need to register
> clock with fixed factor 1.
This is true for now. In the future these clocks will need to be dvfs aware
though. I think it makes sense to have a separate clock then?
> Same comment for dis1-fixed, dsi2-fixed and mipi-cal-fast clocks.
>
Those might not need to become dvfs aware.
> > + /* xusb_host */
> > + clk = tegra_clk_register_periph_gate("xusb_host", "xusb_host_src", 0,
> > + clk_base, 0, 89, &periph_u_regs,
> > + periph_clk_enb_refcnt);
> > + clk_register_clkdev(clk, "tegra_xhci", "host");
> > + clks[xusb_host] = clk;
> > +
> > + /* xusb_ss */
> > + clk = tegra_clk_register_periph_gate("xusb_ss", "xusb_ss_src", 0,
> > + clk_base, 0, 156, &periph_w_regs,
> > + periph_clk_enb_refcnt);
> > + clk_register_clkdev(clk, "tegra_xhci", "ss");
> > + clks[xusb_host] = clk;
> > +
> > + /* xusb_dev */
> > + clk = tegra_clk_register_periph_gate("xusb_dev", "xusb_dev_src", 0,
> > + clk_base, 0, 95, &periph_u_regs,
> > + periph_clk_enb_refcnt);
> > + clk_register_clkdev(clk, "tegra_xhci", "dev");
>
> clks[xusb_dev] = clk;
>
Missing indeed.
Cheers,
Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists