linux-kernel - Re[2]: TDM bus support in Linux Kernel [PATCH]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6757302.20130204160858@promwad.com>
Date:	Mon, 4 Feb 2013 16:08:58 +0300
From:	Michail Kurachkin <michail.kurachkin@...mwad.com>
To:	Oliver Neukum <oneukum@...e.de>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kuten Ivan <Ivan.Kuten@...mwad.com>,
	"benavi@...vell.com" <benavi@...vell.com>,
	Palstsiuk Viktar <Viktar.Palstsiuk@...mwad.com>
Subject: Re[2]: TDM bus support in Linux Kernel [PATCH]

Hi Oliver,

Thank you for the code review. I am working on the sources and soon
will send you the update.

By the way, I did not find suitable implementation of software circular buffer management. src/include/linux/circ_buf.h seems to be very limited solution. 
What do you think about adding the following functions/macros to the global namespace?

int cb_init(struct circ_buf *cb, int item_size, int count);
void cb_free(struct circ_buf *cb);
int cb_push(struct circ_buf *cb, void *item);
int cb_pop(struct circ_buf *cb, void *item);
int cb_is_full(struct circ_buf *cb);
int cb_is_empty(struct circ_buf *cb);

> On Wednesday 30 January 2013 12:37:25 Kurachkin Michail wrote:
>> Hi Greg,
>> 
>> I followed your recommendations and created a diff using Linux 3.8-rc5 sources. Please review it and give your comments.


--
Kurochkin Michail
Software engineer
Promwad Innovation Company
22, Olshevskogo St.,
220073, Minsk, BELARUS
phone: +375 17 312-1246 ext. 801
mobile: +375 29 609-1024
mail: Michail.Kurachkin@...mwad.com
www: www.promwad.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/