linux-kernel - Re: [PATCH] leds-ot200: Fix error caused by shifted mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH9NwWfRL3HpfhLW5FqmWJC+NYHagoQXMoavAzMYciHRDg6mdQ@mail.gmail.com>
Date:	Mon, 4 Feb 2013 15:46:34 +0100
From:	Christian Gmeiner <christian.gmeiner@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"GMEINER.Christian" <C.GMEINER@...hmann.info>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>
Subject: Re: [PATCH] leds-ot200: Fix error caused by shifted mask

2013/2/1 Andrew Morton <akpm@...ux-foundation.org>:
> On Fri, 1 Feb 2013 16:08:15 +0100
> Christian Gmeiner <christian.gmeiner@...il.com> wrote:
>
>> ping
>
> Bryan is handling LEDs patches (see ./MAINTAINERS).  Without a cc he
> presumably missed this in the lkml flood.

You are right...

~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c
Bryan Wu <cooloney@...il.com> (maintainer:LED SUBSYSTEM)
Richard Purdie <rpurdie@...ys.net> (maintainer:LED SUBSYSTEM)
linux-leds@...r.kernel.org (open list:LED SUBSYSTEM)
linux-kernel@...r.kernel.org (open list)

Next time I will add Bryan to CC

>
>> 2013/1/23 GMEINER.Christian <C.GMEINER@...hmann.info>:
>> >> -----Urspr__ngliche Nachricht-----
>> >> Von: Christian Gmeiner [mailto:christian.gmeiner@...il.com]
>> >> Gesendet: Mittwoch, 23. Januar 2013 09:11
>> >> An: linux-next@...r.kernel.org; akpm@...ux-foundation.org;
>> >> rpurdie@...ys.net; linux-kernel@...r.kernel.org; GMEINER.Christian
>> >> Cc: Christian Gmeiner
>> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask
>> >>
>> >> During the development of this driver an in-house register documentation
>> >> was used. The last weeks some integration tests were done and this problem
>> >> was found. It turned out that the released register documentation is wrong.
>> >>
>> >> The fix is very simple: shift all masks by one.
>> >>
>
> The changelog failed to describe the effects of the bug it fixes.  This
> is a grave (and all too common) omission; it makes it difficult for
> others to determine whether the patch should be backported into earlier
> kernels.
>
> So, please tell us.  And feel free to explain whether you believe the
> fix should be backported.

Our customers can control LEDs from userspace via Java, C++ or what every. They
have running/working applications where they want to control led_3 but
led_2 get's
used. I got a bug report in our in-house bug tracker so it would be
great if this patch can make it into 3.7.x series.

thanks
--
Christian Gmeiner, MSc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/