linux-kernel - Re: [PATCH 12.5/62] firewire: add minor number range check to fw_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204191515.4f629dd6@stein>
Date:	Mon, 4 Feb 2013 19:15:15 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Tejun Heo <tj@...nel.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	rusty@...tcorp.com.au, bfields@...ldses.org,
	skinsbursky@...allels.com, ebiederm@...ssion.com,
	jmorris@...ei.org, axboe@...nel.dk,
	linux1394-devel@...ts.sourceforge.net
Subject: Re: [PATCH 12.5/62] firewire: add minor number range check to
 fw_device_init()

On Feb 04 Tejun Heo wrote:
> fw_device_init() didn't check whether the allocated minor number isn't
> too large.  Fail if it goes overflows MINORBITS.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Suggested-by: Stefan Richter <stefanr@...6.in-berlin.de>
> Cc: stable@...r.kernel.org
> ---
>  drivers/firewire/core-device.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/drivers/firewire/core-device.c
> +++ b/drivers/firewire/core-device.c
> @@ -1020,6 +1020,10 @@ static void fw_device_init(struct work_s
>  	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
>  	      idr_get_new(&fw_device_idr, device, &minor) :
>  	      -ENOMEM;
> +	if (minor >= 1 << MINORBITS) {
> +		idr_remove(&fw_device_idr, minor);
> +		minor = -ENOSPC;
> +	}
>  	up_write(&fw_device_rwsem);
>  
>  	if (ret < 0)

Thanks; routing together with the other idr patches through mm Acked-by:
Stefan Richter <stefanr@...6.in-berlin.de>

Not totally sure whether to bother -stable with this, as this condition is
rather difficult to provoke.  But since the fix is small and "obvious",
why not.
-- 
Stefan Richter
-=====-===-= --=- --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/