linux-kernel - [patch] config: fix make kvmconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1302041002430.6063@chino.kir.corp.google.com>
Date:	Mon, 4 Feb 2013 10:20:10 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Pekka Enberg <penberg@...nel.org>,
	Sasha Levin <levinsasha928@...il.com>
cc:	Randy Dunlap <rdunlap@...radead.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Michal Marek <mmarek@...e.cz>, Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: [patch] config: fix make kvmconfig 

make kvmconfig selects CONFIG_SERIAL_8250 without selecting its 
dependencies causing some configs to fail:

drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function)
drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function)
drivers/tty/serial/8250/8250.c: In function 'serial8250_console_write':
drivers/tty/serial/8250/8250.c:2843:10: error: 'struct uart_port' has no member named 'sysrq'
drivers/tty/serial/8250/8250.c: In function 'early_serial_setup':
drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>'
drivers/tty/serial/8250/8250.c: At top level:
drivers/tty/serial/8250/8250.c:2712:30: warning: 'serial8250_ports' defined but not used [-Wunused-variable]

Fix this by selecting CONFIG_TTY as well, which CONFIG_SERIAL_8250 
requires.

Signed-off-by: David Rientjes <rientjes@...gle.com>
---
 Ok, so this patch has been sitting in linux-next for well over a year and
 has had to be fixed several times with follow up commits similar to this.
 Linus hasn't pulled kvmtool, so I'm wondering why we need to keep this
 around in the first place?

 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6979498..f9459b3 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -606,6 +606,7 @@ config KVMTOOL_TEST_ENABLE
 	select NETWORK_FILESYSTEMS
 	select INET
 	select EXPERIMENTAL
+	select TTY
 	select SERIAL_8250
 	select SERIAL_8250_CONSOLE
 	select IP_PNP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/