linux-kernel - Re: [PATCH 10/13] workqueue: add lock_pool_own_work() and remove get_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204213849.GE27963@mtj.dyndns.org>
Date:	Mon, 4 Feb 2013 13:38:49 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/13] workqueue: add lock_pool_own_work() and remove
 get_work_pool()

On Fri, Feb 01, 2013 at 02:41:33AM +0800, Lai Jiangshan wrote:
> lock_pool_own_work() reuse lock_pool_queued_work() and lock_pool_executing_work()
> to implement "get the correct own pool and lock" logic. It makes all callings
> to lock_pool_own_work()'s mean/logic are more clear.
> 
> get_work_pool() can't get the really pool which owns the work
> and it is not used any more, just remove it.
> 
> Add/Use proper locking API.

I like they're being collected into one interface although the name
seems a bit iffy to me.  Maybe mark the original two functions as
internal to the new locking interface?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/