linux-kernel - Re: [PATCH 13/13] workqueue: record global worker ID instead of pool ID in work->data when off-queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204221203.GA8068@mtj.dyndns.org>
Date:	Mon, 4 Feb 2013 14:12:03 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/13] workqueue: record global worker ID instead of pool
 ID in work->data when off-queue

Hello,

One more thing.

On Fri, Feb 01, 2013 at 02:41:36AM +0800, Lai Jiangshan wrote:
> @@ -1216,7 +1198,11 @@ static int try_to_grab_pending(struct work_struct *work, bool is_dwork,
>  		list_del_init(&work->entry);
>  		cwq_dec_nr_in_flight(get_work_cwq(work), get_work_color(work));
>  
> -		clear_work_cwq(work, pool->id);
> +		/* Does the work is still running? */
> +		worker = find_worker_executing_work(pool, work);
> +		worker_gwid = worker ? worker->gwid: WORK_OFFQ_WORKER_NONE;
> +		clear_work_cwq(work, worker_gwid);

Any chance we can remove the busy_hash?  Having to keep it around
isn't a big deal but it would be nice if can get rid of it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/