linux-kernel - Re: [PATCH 4/5] iommu: Add domain window handling functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALRxmdD9Ock04AoUtF9FT_uY5C5Eb7cSPmtCM6WK=StNB_iYkQ@mail.gmail.com>
Date:	Mon, 4 Feb 2013 17:31:51 -0600
From:	Stuart Yoder <b08248@...il.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Sethi Varun-B16395 <B16395@...escale.com>,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] iommu: Add domain window handling functions

On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel <joro@...tes.org> wrote:
> On Mon, Feb 04, 2013 at 12:10:51PM -0600, Stuart Yoder wrote:
>> On Mon, Feb 4, 2013 at 7:18 AM, Joerg Roedel <joro@...tes.org> wrote:
>> > +static inline int iommu_domain_window_enable(struct iommu_domain *domain,
>> > +                                            u32 wnd_nr, phys_addr_t paddr,
>> > +                                            size_t size)
>> > +{
>> > +       return -ENODEV;
>> > +}
>> > +
>> > +static inline void iommu_domain_window_disable(struct iommu_domain *domain,
>> > +                                              u32 wnd_nr)
>> > +{
>> > +}
>> > +
>> >  static inline phys_addr_t iommu_iova_to_phys(struct iommu_domain *domain,
>> >                                              unsigned long iova)
>> >  {
>>
>> This API looks workable.   The one change we need is that the size argument in
>> the enable API needs to be 64 bits.   Our window sizes can exceed 4GB.
>
> Okay. So if your architecture supports sizes over 2^32 then size_t
> probably is already 64bits, right?

No, on a 32-bit platform size_t would generally be 32-bits.  But the PAMU
is independent of that.   I think we should just make it a u64.

Stuart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/