linux-kernel - [PATCH] kdump: do not drop entire e820 in crash kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1U2DId-0001E4-Df@eag09.americas.sgi.com>
Date:	Sun, 03 Feb 2013 22:04:55 -0600
From:	Cliff Wickman <cpw@....com>
To:	linux-kernel@...r.kernel.org
Cc:	mingo@...e.hu, hpa@...or.com, venkatesh.pallipadi@...el.com,
	kexec@...ts.infradead.org
Subject: [PATCH] kdump: do not drop entire e820 in crash kernel

From: Cliff Wickman <cpw@....com>

The crash kernel is not able to find its root device if that device is not
on PCI 0.

This is because it is booted with the command line option memmap=exactmap
which currently clears the e820 table.  So ACPI processing does not
find reserved i/o spaces. 

This works for a device on PCI 0 because ACPI falls back to a legacy mode.
But the error message " [Firmware Bug]: PCI: MMCONFIG at
 [mem 0x80000000-0x80cfffff] not reserved in ACPI motherboard resources"
is written to the log even in this functioning case.

It fails for some devices on UV2, and only for UV2, because SGI seems to
be the only manufacturer currently using the extended PCI(>0).

The fix is to not drop the entire e820 table on a memmap=exactmap, but
to preserve all the non-E820_RAM reservations that the BIOS has made.

Signed-off-by: Cliff Wickman <cpw@....com>
---
 arch/x86/kernel/e820.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Index: linus.current/arch/x86/kernel/e820.c
===================================================================
--- linus.current.orig/arch/x86/kernel/e820.c
+++ linus.current/arch/x86/kernel/e820.c
@@ -839,6 +839,8 @@ static int __init parse_memmap_opt(char
 {
 	char *oldp;
 	u64 start_at, mem_size;
+	int i;
+	struct e820entry *curp, *availp;

 	if (!p)
 		return -EINVAL;
@@ -852,7 +854,17 @@ static int __init parse_memmap_opt(char
 		 */
 		saved_max_pfn = e820_end_of_ram_pfn();
 #endif
-		e820.nr_map = 0;
+		/* keep everything that was reserved by the BIOS */
+		for (i = 0, curp = &e820.map[0], availp = &e820.map[0];
+						i < e820.nr_map; i++, curp++) {
+			if (curp->type != E820_RAM) {
+				if (curp != availp) {
+					*availp = *curp;
+					availp++;
+				}
+			}
+		}
+		e820.nr_map = availp - &e820.map[0];
 		userdef = 1;
 		return 0;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/