linux-kernel - Re: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130205083828.GE32118@arwen.pp.htv.fi>
Date:	Tue, 5 Feb 2013 10:38:28 +0200
From:	Felipe Balbi <balbi@...com>
To:	kishon <kishon@...com>
CC:	Sergei Shtylyov <sshtylyov@...sta.com>, <balbi@...com>,
	<b-cousson@...com>, <tony@...mide.com>, <linux@....linux.org.uk>,
	<s-guiriec@...com>, <gg@...mlogic.co.uk>,
	<linux-omap@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data

On Tue, Feb 05, 2013 at 01:59:26PM +0530, kishon wrote:
> On Sunday 27 January 2013 01:17 AM, Sergei Shtylyov wrote:
> >Hello.
> >
> >On 25-01-2013 15:11, Kishon Vijay Abraham I wrote:
> >
> >>Add dwc3 omap glue data to the omap5 dt data file. The information about
> >>the dt node added here is available @
> >>Documentation/devicetree/bindings/usb/omap-usb.txt
> >
> >>Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> >>---
> >>  arch/arm/boot/dts/omap5.dtsi |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >
> >>diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> >>index 5f59bf2..1703a72 100644
> >>--- a/arch/arm/boot/dts/omap5.dtsi
> >>+++ b/arch/arm/boot/dts/omap5.dtsi
> >>@@ -513,6 +513,17 @@
> >>              ti,type = <2>;
> >>          };
> >>
> >>+        omap_dwc3@...20000 {
> >>+            compatible = "ti,dwc3";
> >>+            ti,hwmods = "usb_otg_ss";
> >>+            reg = <0x4a020000 0x1ff>;
> >
> >    Shoudn't the "reg" length be 0x200 here? It's length, not limit.
> 
> I think 0x1ff is correct. I got the data from hwmod data.

hwmod is utterly wrong. Looking at TRM, it says the size here is 64KiB
(0x10000), so is the size for dwc3 itself. Please don't blindly trust
hwmod, make sure you read data from TRM ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)