linux-kernel - Re: [PATCH 1/2] spi: make sure all transfer has proper speed set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130205131122.8C84A3E0E27@localhost>
Date:	Tue, 05 Feb 2013 13:11:22 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, swarren@...dia.com,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH 1/2] spi: make sure all transfer has proper speed set

On Sat, 5 Jan 2013 00:17:14 +0530, Laxman Dewangan <ldewangan@...dia.com> wrote:
> When spi client does the spi transfer and if it does not set
> the speed for each transfer then set it as default
> of spi device in spi core before calling low level transfer.
> 
> This will remove the extra check in low level driver for setting
> speed.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

Applied, thanks.

g.

> ---
>  drivers/spi/spi.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 19ee901..9676a29 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1366,12 +1366,14 @@ static int __spi_async(struct spi_device *spi, struct spi_message *message)
>  	}
>  
>  	/**
> -	 * Set transfer bits_per_word as spi device default if it is not
> -	 * set for this transfer.
> +	 * Set transfer bits_per_word and max speed as spi device default if
> +	 * it is not set for this transfer.
>  	 */
>  	list_for_each_entry(xfer, &message->transfers, transfer_list) {
>  		if (!xfer->bits_per_word)
>  			xfer->bits_per_word = spi->bits_per_word;
> +		if (!xfer->speed_hz)
> +			xfer->speed_hz = spi->max_speed_hz;
>  	}
>  
>  	message->spi = spi;
> -- 
> 1.7.1.1
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/