linux-kernel - Re: [PATCH] init: fix name of root device in /proc/mounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1360032141.12062.12@driftwood>
Date:	Mon, 04 Feb 2013 20:42:21 -0600
From:	Rob Landley <rob@...dley.net>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	William Hubbs <w.d.hubbs@...il.com>, linux-kernel@...r.kernel.org,
	mpagano@...too.org
Subject: Re: [PATCH] init: fix name of root device in /proc/mounts

On 01/31/2013 05:22:09 PM, H. Peter Anvin wrote:
> On 01/31/2013 02:51 PM, William Hubbs wrote:
> > On a system that does not use an initramfs, /dev/root was always
> > listed in /proc/mounts. This breaks software which scans  
> /proc/mounts to
> > determine which file systems are mounted since /dev/root is not a  
> valid
> > device name.
> >
> > This changes that processing so that "/dev/root" is only added to
> > /proc/mounts if a root device is not specified with the root=  
> option on
> > the kernel command line.
> >
> > Signed-off-by: William Hubbs <w.d.hubbs@...il.com>
> 
> Let me also point out that most of the time, the kernel actually has a
> udev device name for an actual device...

So your software is broken by overmounts? /dev/root is just one example  
of this. (And you can specify a root= on the kernel command line and  
have that be parsed by initramfs. I vaguely recall klibc does this...)

For an example of how to parse this stuff, how about:

   http://landley.net/hg/toybox/file/4ffb735aea59/toys/posix/df.c

I.E. parse from the end of the list (most recent match is the  
overmount), and eliminate synthetic filesystems. Note that code is from  
2006, other people have managed to cope all this time...

Rob--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/