linux-kernel - Re: [PATCH] mm: break circular include from linux/mmzone.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130205131801.131dabb1.akpm@linux-foundation.org>
Date:	Tue, 5 Feb 2013 13:18:01 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	li guang <lig.fnst@...fujitsu.com>
Cc:	David Rientjes <rientjes@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: break circular include from linux/mmzone.h

On Tue, 05 Feb 2013 13:56:36 +0800
li guang <lig.fnst@...fujitsu.com> wrote:

> ___ 2013-02-04______ 21:20 -0800___David Rientjes_________
> > On Tue, 5 Feb 2013, liguang wrote:
> > 
> > > linux/mmzone.h included linux/memory_hotplug.h,
> > > and linux/memory_hotplug.h also included
> > > linux/mmzone.h, so there's a bad cirlular.
> > > 
> > 
> > And both of these are protected by _LINUX_MMZONE_H and 
> > __LINUX_MEMORY_HOTPLUG_H, respectively, so what's the problem?
> 
> obviously, It's a logical error,
> and It has no more effect other than
> combination of these 2 header files.
> so, why don't we separate them?
> 

Yup, flattening the hierarchy is nice.  And having headers doing mutual
inclusion like this is Just Weird.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/