linux-kernel - Re: [ 105/128] efi: Make efi_enabled a function to query EFI facilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1360035964.32217.9.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 05 Feb 2013 03:46:04 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Matt Fleming <matt.fleming@...el.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, David Airlie <airlied@...ux.ie>,
	Corentin Chary <corentincj@...aif.net>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Dave Jiang <dave.jiang@...el.com>,
	Olof Johansson <olof@...om.net>,
	Peter Jones <pjones@...hat.com>,
	Colin Ian King <colin.king@...onical.com>,
	Steve Langasek <steve.langasek@...onical.com>,
	Tony Luck <tony.luck@...el.com>,
	Konrad Rzeszutek Wilk <konrad@...nel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [ 105/128] efi: Make efi_enabled a function to query EFI
 facilities

On Mon, 2013-02-04 at 16:44 +0000, Matt Fleming wrote:
> On Sun, 2013-02-03 at 16:15 +0100, Ben Hutchings wrote:
> > As you can see this needed quite a lot of work to backport, and I
> > haven't been able to test it yet.  So I would particularly appreciate
> > careful review of this.
> 
> Everything looks fine to me but I haven't actually booted with these
> changes.

Thanks.  I've now tested this on a 64-bit EFI system myself:

x86_64 kernel build:
- Boots successfully
- x86_efi_facilities = 0x3f
- efifb works
- efivars can be loaded and creates /sys/firmware/efi/vars

i386 kernel build:
- Boots as far as an initramfs shell, but the machine doesn't have an
i386 installation to continue with
- x86_efi_facilities = 0x21
- efifb works
- efivars can be loaded but does nothing

All of which I think is correct.

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert Einstein

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)