linux-kernel - [PATCH 1/1]linux-usb: fix the product IDs to be little endian in initializers.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Feb 2013 17:24:12 +0800
From:	fangxiaozhi 00110321 <fangxiaozhi@...wei.com>
To:	<linux-usb@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>, <zihan@...wei.com>,
	<Lin.Lei@...wei.com>, <greg@...ah.com>, <neil.yi@...wei.com>,
	<wangyuhua@...wei.com>, <huqiao36@...wei.com>, <balbi@...com>,
	<mdharm-usb@...-eyed-alien.net>, <sebastian@...akpoint.cc>
Subject: [PATCH 1/1]linux-usb: fix the product IDs to be little endian
 in initializers.c

From: fangxiaozhi <huananhu@...wei.com>

1. The idProduct is little endian, so make the product ID's value to be little endian. Make no break on big endian processors.

Signed-off-by: fangxiaozhi <huananhu@...wei.com>
--------------------------------------------------------------------

diff -uprN linux-3.8-rc6_orig/drivers/usb/storage/initializers.c linux-3.8-rc6/drivers/usb/storage/initializers.c
--- linux-3.8-rc6_orig/drivers/usb/storage/initializers.c	2013-02-06 14:48:51.564355283 +0800
+++ linux-3.8-rc6/drivers/usb/storage/initializers.c	2013-02-06 15:11:40.925434289 +0800
@@ -152,12 +152,15 @@ static int usb_stor_huawei_dongles_pid(s
 	 * means the dongle in the single port mode,
 	 * and a switch command is required to be sent. */
 	if (idesc && idesc->bInterfaceNumber == 0) {
-		if ((idProduct == 0x1001)
-			|| (idProduct == 0x1003)
-			|| (idProduct == 0x1004)
-			|| (idProduct >= 0x1401 && idProduct <= 0x1500)
-			|| (idProduct >= 0x1505 && idProduct <= 0x1600)
-			|| (idProduct >= 0x1c02 && idProduct <= 0x2202)) {
+		if ((idProduct == cpu_to_le16(0x1001))
+			|| (idProduct == cpu_to_le16(0x1003))
+			|| (idProduct == cpu_to_le16(0x1004))
+			|| (idProduct >= cpu_to_le16(0x1401)
+				&& idProduct <= cpu_to_le16(0x1500))
+			|| (idProduct >= cpu_to_le16(0x1505)
+				&& idProduct <= cpu_to_le16(0x1600))
+			|| (idProduct >= cpu_to_le16(0x1c02)
+				&& idProduct <= cpu_to_le16(0x2202))) {
 			return 1;
 		}
 	}
@@ -169,7 +172,7 @@ int usb_stor_huawei_init(struct us_data
 	int result = 0;
 
 	if (usb_stor_huawei_dongles_pid(us)) {
-		if (us->pusb_dev->descriptor.idProduct >= 0x1446)
+		if (us->pusb_dev->descriptor.idProduct >= cpu_to_le16(0x1446))
 			result = usb_stor_huawei_scsi_init(us);
 		else
 			result = usb_stor_huawei_feature_init(us);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/