linux-kernel - Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130206112231.GI22064@arwen.pp.htv.fi>
Date:	Wed, 6 Feb 2013 13:22:31 +0200
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
CC:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Kishon Vijay Abraham I <kishon@...com>,
	<gregkh@...uxfoundation.org>, <tony@...mide.com>,
	<eballetbo@...il.com>, <javier@...hile0.org>, <b-cousson@...com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox

Hi again,

On Wed, Feb 06, 2013 at 01:03:55PM +0200, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Feb 06, 2013 at 10:57:13AM +0000, Russell King - ARM Linux wrote:
> > On Wed, Feb 06, 2013 at 11:28:11AM +0530, Kishon Vijay Abraham I wrote:
> > > Added has_mailbox to the musb platform data to specify that omap uses
> > > an external mailbox (in control module) to communicate with the musb
> > > core during device connect and disconnect.
> > 
> > So, I've been through your five patches looking for any other users of
> > "has_mailbox" and I can find none.  You introduce this in this patch,
> > and you set it.  But I don't see anything that uses it.
> > 
> > Write only variables are not useful.
> 
> looking back at what I sent Greg this was probably my fault. When taking
> Kishon's patches (in particular $SUBJECT) I removed some of arch/arm/
> code and ended up forgetting to add the include file which introduces
> has_mailbox.
> 
> This means that my lack of attention has introduced a compile break on
> Greg's tree. Oh well, s**t happens. In any case, the user is already in
> Greg's tree and there's no way Greg will rebase his tree to amend
> $SUBJECT there, so it will have to go separately.
> 
> I didn't even notice this before because I had the diff in my tree, just
> forgot to git add and/or git reset. Too late now

there's a little more to it. When running allmodconfig,
CONFIG_ARCH_MULTIPLATFORM is set but none of the other ARCHes
(ARCH_OMAP, ARCH_AT91, ARCH_VERSATILE, etc) are set, so it turned out
that the driver wasn't even included on my build test.

Russell, is this expected (the MULTIPLATFORM thing) ? Just so I fix my
build test scripts to use another defconfig instead of allmod and
allyes.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)