linux-kernel - Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3571679.eOuhae6qJb@number-5>
Date:	Wed, 06 Feb 2013 15:26:04 +0100
From:	Federico Vaga <federico.vaga@...il.com>
To:	Hans Verkuil <hansverk@...co.com>
Cc:	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Giancarlo Asnaghi <giancarlo.asnaghi@...com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

Hi Hans,

thank you very much for your review and your patience.

> OK, I'm going to give this my Acked-by, but I really wish you would
> have split this up into smaller changes. It's hard to review since
> you have made so many changes in this one patch. Even though I'm
> giving my ack, Mauro might decide against it, so if you have time
> to spread out the changes in multiple patches, then please do so.

I tried to do smaller patch but there is always some incoherent part 
and the driver cannot work without all the patches. I should write 
some "fake" patches to make a coherent series.
I reduce the size of the patch since v4/5; I leaved 
unchanged some code/comments to simplify the patch.

> So, given the fact that this changes just a single driver not
> commonly used in existing deployments, assuming that you have
> tested the changes (you did that, right? Just checking...), that
> these are really useful improvements, and that I reviewed the code
> (as well as I could) and didn't see any problems, I'm giving my ack
> anyway:

Tested every time I sent a patch

> Acked-by: Hans Verkuil <hans.verkuil@...co.com>

Thank you again

-- 
Federico Vaga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/