linux-kernel - Re: [PATCH] unbreak automounter support on 64-bit kernel with 32-bit userspace (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130206172120.GJ26454@arm.com>
Date:	Wed, 6 Feb 2013 17:21:20 +0000
From:	Catalin Marinas <catalin.marinas@....com>
To:	Helge Deller <deller@....de>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	John David Anglin <dave.anglin@...l.net>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	Ian Kent <raven@...maw.net>,
	"autofs@...r.kernel.org" <autofs@...r.kernel.org>
Subject: Re: [PATCH] unbreak automounter support on 64-bit kernel with
 32-bit userspace (v2)

On Mon, Feb 04, 2013 at 07:39:52PM +0000, Helge Deller wrote:
> automount-support is broken on the parisc architecture, because the existing
> #if list does not include a check for defined(__hppa__). The HPPA (parisc)
> architecture is similiar to other 64bit Linux targets where we have to define
> autofs_wqt_t (which is passed back and forth to user space) as int type which
> has a size of 32bit across 32 and 64bit kernels.
> 
> During the discussion on the mailing list, H. Peter Anvin suggested to invert
> the #if list since only specific platforms (specifically those who do not have
> a 32bit userspace, like IA64 and Alpha) should have autofs_wqt_t as unsigned
> long type.
> 
> This suggestion is probably the best way to go, since Arm64 (and maybe others?)
> seems to have a non-working automounter. So in the long run even for other new
> upcoming architectures this inverted check seem to be the best solution, since
> it will not require them to change this #if again (unless they are 64bit only).
> 
> Signed-off-by: Helge Deller <deller@....de>
> CC: James Bottomley <James.Bottomley@...senPartnership.com>
> CC: Catalin Marinas <catalin.marinas@....com>
> CC: Rolf Eike Beer <eike-kernel@...tec.de>
> CC: H. Peter Anvin <hpa@...or.com>
> CC: Ian Kent <raven@...maw.net>

Acked-by: Catalin Marinas <catalin.marinas@....com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/