linux-kernel - Re: [PATCH 3/4] Add the code to send the consigned time from the host to the guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5112C889.7050308@redhat.com>
Date:	Wed, 06 Feb 2013 16:18:01 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Michael Wolf <mjw@...ux.vnet.ibm.com>
CC:	linux-kernel@...r.kernel.org, gleb@...hat.com, kvm@...r.kernel.org,
	peterz@...radead.org, mtosatti@...hat.com, glommer@...allels.com,
	mingo@...hat.com, anthony@...emonkey.ws
Subject: Re: [PATCH 3/4] Add the code to send the consigned time from the
 host to the guest

On 02/05/2013 04:49 PM, Michael Wolf wrote:
> Change the paravirt calls that retrieve the steal-time information
> from the host.  Add to it getting the consigned value as well as
> the steal time.
>
> Signed-off-by: Michael Wolf <mjw@...ux.vnet.ibm.com>

> diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h
> index 06fdbd9..55d617f 100644
> --- a/arch/x86/include/uapi/asm/kvm_para.h
> +++ b/arch/x86/include/uapi/asm/kvm_para.h
> @@ -42,9 +42,10 @@
>
>   struct kvm_steal_time {
>   	__u64 steal;
> +	__u64 consigned;
>   	__u32 version;
>   	__u32 flags;
> -	__u32 pad[12];
> +	__u32 pad[10];
>   };

The function kvm_register_steal_time passes the address of such
a structure to the host kernel, which then does something with
it.

Could running a guest with the above patch, on top of a host
with the old code, result in the values for "version" and
"flags" being written into "consigned"?

Could that result in confusing the guest kernel to no end,
and generally breaking things?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/