linux-kernel - Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51134D7B.5070709@asix.com.tw>
Date:	Thu, 07 Feb 2013 14:45:15 +0800
From:	Freddy <freddy@...x.com.tw>
To:	freddy@...x.com.tw
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0
 to gigabit ethernet adapter driver

On 02/07/2013 01:45 PM, Stephen Hemminger wrote:
> On Thu,  7 Feb 2013 12:36:34 +0800
> Freddy Xin <freddy@...x.com.tw> wrote:
>
>> +struct {unsigned char ctrl, timer_l, timer_h, size, ifg; }
>> +AX88179_BULKIN_SIZE[] =	{
>> +	{7, 0x4f, 0,	0x12, 0xff},
>> +	{7, 0xf0, 1,	0x15, 0xff},
>> +	{7, 0xae, 7,	0x18, 0xff},
>> +	{7, 0xcc, 0x4c, 0x18, 8},
>> +};
>   Better to make it static, const, and add a couple
>   of line breaks.
>
>   static const struct {
>        unsigned char ctrl, timer_l, timer_h, size, ifg;
>   } AX88179_BULKIN_SIZE[] =	{
> 	{7, 0x4f, 0,	0x12, 0xff},
> 	{7, 0xf0, 1,	0x15, 0xff},
> 	{7, 0xae, 7,	0x18, 0xff},
> 	{7, 0xcc, 0x4c, 0x18, 8},
> };
Thank you, Stephen. I will fix these errors.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/