linux-kernel - Re: [PATCH] vmalloc: Remove alloc_map from vmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130207081115.GA1094@cmpxchg.org>
Date:	Thu, 7 Feb 2013 03:11:15 -0500
From:	Johannes Weiner <hannes@...xchg.org>
To:	Chanho Min <chanho.min@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Cong Wang <amwang@...hat.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

Hi Chanho,

On Thu, Feb 07, 2013 at 11:27:54AM +0900, Chanho Min wrote:
> There is no reason to maintain alloc_map in the vmap_block.
> The use of alloc_map may require heavy bitmap operation sometimes.
> In the worst-case, We need 1024 for-loops to find 1 free bit and
> thus cause overhead. vmap_block is fragmented unnecessarily by
> 2 order alignment as well.
> 
> Instead we can map by using vb->free in order. When It is freed,
> Its corresponding bit will be set in the dirty_map and all
> free/purge operations are carried out in the dirty_map.
> vmap_block is not fragmented sporadically anymore and thus
> purge_fragmented_blocks_thiscpu in the vb_alloc can be removed.

I submitted a similar patch some time ago, but at the time Mel
suggested instead to figure out if this bitmap was not supposed to be
doing something useful and depending on that implement recycling of
partially used vmap blocks.

Here is the thread:

https://lkml.org/lkml/2011/4/14/619

I started looking for workloads to profile but then lost interest.
The current code can theoretically end up walking through a lot of
partially used blocks if a string of allocations never fit any of
them.  The number of these blocks depends on previous allocations that
leave them unusable for future allocations and whether any other
vmalloc/vmap user recently flushed them all.  So it's painful to think
about it and hard to impossible to pin down should this ever actually
result in a performance problem.

Either way, short of an actual fix I suspect this patch will pop up
again as it removes currently dead code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/